-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
i18n(es): update tutorial #12629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
i18n(es): update tutorial #12629
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added 3 minor issues. Amazing work!
| </Fragment> | ||
| </PackageManagerTabs> | ||
|
|
||
| 2. Escribe `y` para instalar `create-astro`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This 2. point is duplicated in the next line.
This one looks better, so I would delete the L52.
|
|
||
| <Steps> | ||
| 1. Actualiza `Navigation.astro` con la clase CSS para controlar tus enlaces de navegación. Envuelve los enlaces de navegación existentes en un `<div>` con la clase `nav-links`. | ||
| 1. Actualiza `Navigation.astro` con la clase CSS para controlar tus enlaces de navegación. Envuelve los enlaces de navegación existentes en un `<div>` con la clase `nav-links` y el atributo `id` establecido como `main-menu`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The id is not formatted as code in the English docs. I think it's better like you wrote it, but I don't know if it should be kept as English docs for consistency.
| 1. Update `Navigation.astro` with the CSS class to control your navigation links. Wrap the existing navigation links in a `<div>` with the class `nav-links` and the id attribute set to `main-menu`. |
| ] | ||
| } | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The semicolon should be placed in the array closure
| ] | |
| } | |
| }; | |
| ]; | |
| } |
Description (required)
Related issues & labels (optional)